-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing alpine tag during buildx bake #4043
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bake recipt was missing the single `:alpine` tag for the alpine builds when we were releasing a `stable/latest` version of Vaultwarden. This PR fixes this by checking for those conditions and add the `:alpine` tag too. We will keep the `:latest-alpine` also, which i find even nicer then just `:alpine` Fixes dani-garcia#4035
dani-garcia
approved these changes
Nov 7, 2023
truecharts-admin
referenced
this pull request
in truecharts/public
Nov 20, 2023
…30.1 (#15141) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | patch | `1.30.0` -> `1.30.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (docker.io/vaultwarden/server)</summary> ### [`v1.30.1`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.1) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.0...1.30.1) This is a minor release to fix some issues with the `Login with device` feature, and restore the `alpine` docker tag that was missing on the latest release.⚠️ **Note:** The WebSockets service for live sync has been integrated in the main HTTP server, which means simpler proxy setups that don't require a separate rule to redirect WS traffic to port 3012. Please check the updated examples in the [wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples). It's recommended to migrate to this new setup as using the old server on port 3012 is deprecated, won't receive new features and will be removed in a future release. #### What's Changed - Fix missing alpine tag during buildx bake by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4043](https://togithub.com/dani-garcia/vaultwarden/pull/4043) - Disable autofill-v2 by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4056](https://togithub.com/dani-garcia/vaultwarden/pull/4056) - Add Protected Actions Check by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4067](https://togithub.com/dani-garcia/vaultwarden/pull/4067) - Update crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4074](https://togithub.com/dani-garcia/vaultwarden/pull/4074) **Full Changelog**: dani-garcia/vaultwarden@1.30.0...1.30.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy42MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuNjEuMyIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
arthurgeek
referenced
this pull request
in arthurgeek/vaultwarden-fly-template
Dec 10, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | stage | patch | `1.30.0-alpine` -> `1.30.1-alpine` | --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (vaultwarden/server)</summary> ### [`v1.30.1`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.1) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.0...1.30.1) This is a minor release to fix some issues with the `Login with device` feature, and restore the `alpine` docker tag that was missing on the latest release.⚠️ **Note:** The WebSockets service for live sync has been integrated in the main HTTP server, which means simpler proxy setups that don't require a separate rule to redirect WS traffic to port 3012. Please check the updated examples in the [wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples). It's recommended to migrate to this new setup as using the old server on port 3012 is deprecated, won't receive new features and will be removed in a future release. #### What's Changed - Fix missing alpine tag during buildx bake by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4043](https://togithub.com/dani-garcia/vaultwarden/pull/4043) - Disable autofill-v2 by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4056](https://togithub.com/dani-garcia/vaultwarden/pull/4056) - Add Protected Actions Check by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4067](https://togithub.com/dani-garcia/vaultwarden/pull/4067) - Update crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4074](https://togithub.com/dani-garcia/vaultwarden/pull/4074) **Full Changelog**: dani-garcia/vaultwarden@1.30.0...1.30.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly-template). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
arthurgeek
referenced
this pull request
in arthurgeek/vaultwarden-fly
Dec 10, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | stage | patch | `1.30.0-alpine` -> `1.30.1-alpine` | --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (vaultwarden/server)</summary> ### [`v1.30.1`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.1) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.0...1.30.1) This is a minor release to fix some issues with the `Login with device` feature, and restore the `alpine` docker tag that was missing on the latest release.⚠️ **Note:** The WebSockets service for live sync has been integrated in the main HTTP server, which means simpler proxy setups that don't require a separate rule to redirect WS traffic to port 3012. Please check the updated examples in the [wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples). It's recommended to migrate to this new setup as using the old server on port 3012 is deprecated, won't receive new features and will be removed in a future release. #### What's Changed - Fix missing alpine tag during buildx bake by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4043](https://togithub.com/dani-garcia/vaultwarden/pull/4043) - Disable autofill-v2 by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4056](https://togithub.com/dani-garcia/vaultwarden/pull/4056) - Add Protected Actions Check by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4067](https://togithub.com/dani-garcia/vaultwarden/pull/4067) - Update crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/4074](https://togithub.com/dani-garcia/vaultwarden/pull/4074) **Full Changelog**: dani-garcia/vaultwarden@1.30.0...1.30.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bake recipt was missing the single
:alpine
tag for the alpine builds when we were releasing astable/latest
version of Vaultwarden.This PR fixes this by checking for those conditions and add the
:alpine
tag too.We will keep the
:latest-alpine
also, which i find even nicer then just:alpine
Fixes #4035