Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json2csv update: handle lists of coordinates #1652

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes
Adjust the json2csv utility function to handle lists of coordinates e.g. leaf tip coordinates from the morphology subpackage.

Type of update
Is this a:

  • Bug fix (previously json2csv would run but would have squished syntax, and this bad syntax would throw an error while reading the resulting csv in with pandas as a dataframe)
  • feature enhancement
  • Work in progress

Associated issues

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added enhancement Enhancements to existing features bugfix Bug fixes work in progress Mark work in progress update Updates an existing feature/method labels Jan 17, 2025
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.7 milestone Jan 17, 2025
@HaleySchuhl HaleySchuhl self-assigned this Jan 17, 2025
Copy link

deepsource-io bot commented Jan 17, 2025

Here's the code health analysis summary for commits c6105a7..f6d1944. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl added ready to review and removed work in progress Mark work in progress labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes enhancement Enhancements to existing features ready to review update Updates an existing feature/method
Projects
Status: Pull Requests
Development

Successfully merging this pull request may close these issues.

1 participant