Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactoring uses of web3 #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BboyAkers
Copy link

@BboyAkers BboyAkers commented Feb 7, 2021

TODO:

  • Need to understand the signing alternative to web3.eth.sign()

@BboyAkers BboyAkers marked this pull request as draft February 7, 2021 06:14
index.js Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@BboyAkers
Copy link
Author

@danfinlay Just about finished 🙂

eth_sign button is outputting this error in the console on click:

MetaMask - RPC Error: e.slice is not a function {code: -32603, message: "e.slice is not a function", data: {…}}

sign typed data with ethjs button is outputting this error in the console on click:

Uncaught (in promise) TypeError: Cannot read property 'EIP712Domain' of undefined
    at Object.findTypeDependencies (bundle.js:12916)
    at Object.encodeType (bundle.js:12893)
    at Object.hashType (bundle.js:12948)
    at Object.encodeData (bundle.js:12808)
    at Object.hashStruct (bundle.js:12937)
    at Object.sign (bundle.js:12977)
    at Object.recoverTypedSignature (bundle.js:13220)
    at HTMLButtonElement.<anonymous> (bundle.js:449)

I think it's having to do with the msgParams structure and EIP712Domain no being in it. Not sure of the structure for that.

Any ideas on these errors?

@BboyAkers BboyAkers marked this pull request as ready for review February 18, 2021 04:39
@BboyAkers
Copy link
Author

Going to bump this @danfinlay. I know you're stacked with stuff, when you're free can you review this? 😄

@BboyAkers
Copy link
Author

@danfinlay Bumping again 🙂. Can you look into the eth_sign method and the sign typed data with ethjs. Everything else seems to be looking great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants