Adding JPEG autorotation #841
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds automatic image rotation for JPEG images with orientation EXIF data. Almost all cell phone cameras store the image data in an un-rotated state, and write EXIF data to indicate "which side should be up". All modern browsers understand these EXIF tags and automatically orient the image correctly. Thus, when the pictures are viewed in a web page they appear correct. When the page is output to PDF, however, the image is rotated. This change modifies the pdfboximage class to read the EXIF data (if it exists) and rotate the image if necessary. This results in a "rotate on load" behavior (i.e. before the resource cache), so the rotation only needs to be done once, even if the image appears multiple times in the document.
* Fixed some whitespace that was accidentally changed. * Removed a debug flag from the parent pom.
|
hi, @danfickle Any plans to merge the pr? Thanks |
|
Hi @danfickle @Dunemaster @smahnken Any update on this PR? Running into the same issue at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds automatic image rotation for JPEG images with orientation EXIF data.
Almost all cell phone cameras store the image data in an un-rotated state, and write EXIF data to indicate "which side should be up". All modern browsers understand these EXIF tags and automatically orient the image correctly. Thus, when the pictures are viewed in a web page they appear correct. When the page is output to PDF, however, the image is rotated.
This change modifies the pdfboximage class to read the EXIF data (if it exists) and rotate the image data if necessary. This results in a "rotate on load" behavior (i.e. before the resource cache), so the rotation only needs to be done once, even if the image appears multiple times in the document.
This change utilizes the apache-commons imaging library (which is currently in alpha-3) to read the EXIF data.
Please go easy on me. This is my first pull request. Let me know if I've done something incorrectly, and I'll do my best to comply.