forked from DailyDreaming/linkml-aind-model
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major refactoring to support more thorough conversion of dandischema pydantic models #1
Open
yarikoptic
wants to merge
204
commits into
main
Choose a base branch
from
enh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow classes to be input as positional argument makes the function more portable
This func is intended to be used for converting a docstring to description in metadata in a LinkML schema
A method that adds the slots construed from the models in `self._models` to the schema
In generate_linkml_from_aind.py
`fetch_defs()` is a function for fetching Python objects from given modules that provide schema definitions
The use of `from __future__ import annotations` solicit hard to predict behaviors from Pydantic and Typer in older Python versions
The use of `from __future__ import annotations` solicit hard to predict behaviors from Pydantic and Typer in older Python versions
`pydantic.BaseModel` doesn't really model anything. It is merely a template to specify a model.
Pydantic 2.9 adds support of validation of complex numbers. To be compatible with Pydantic 2.9, We need this interface defined.
Pydantic 2.8 doesn't have "core_schema.ComplexSchema" needed in the current code. Let's support Pydantic 2.8 only when needed
Due to the transfer of the project to the DANDI organization on github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done locally to replace