-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TF configuration for ImprovMX #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The run that is linked to this PR has a warning about the use of environment variables; I mistakenly included the ImprovMX API token as a "terraform" variable rather than "environment" but I've since fixed that and subsequent runs don't show that warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, including reverting 7ecdd07 if you'd like.
@waxlamp could you please add a very brief description on what improvMX is and why is it being added? |
Hi @yarikoptic, here is the overview: https://docs.dandiarchive.org/40_development/#dns-entries-for-public-email-addresses |
coolio, thanks @kabilar , I updated PR description |
This PR brings our management of ImprovMX resources under the Terraform umbrella. This will provide better visibility and the ability for other team members to make updates to our email forwarding infrastructure without having to gain access to the ImprovMX account directly.
See the documentation on email forwarding for more details on our use of ImprovMX in this project.