Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable manifest garbage collection in prod #206

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Enable manifest garbage collection in prod #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions terraform/modules/dandiset_bucket/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,8 +347,7 @@ resource "aws_s3_bucket_lifecycle_configuration" "dandiset_bucket" {
# S3 lifecycle policy that garbage collects old manifest file versions
dynamic "rule" {
# Only create this rule if versioning is enabled and we want to expire old manifest file versions
# TODO: remove enable_manifest_file_expiration once we are ready to deploy this to production
for_each = var.versioning && var.enable_manifest_file_expiration ? [1] : []
for_each = var.versioning ? [1] : []

content {
id = "ExpireOldManifestFileVersions"
Expand Down
7 changes: 0 additions & 7 deletions terraform/modules/dandiset_bucket/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,3 @@ variable "log_bucket_name" {
type = string
description = "The name of the log bucket."
}

# TODO: remove this after it's ready to be enabled in production
variable "enable_manifest_file_expiration" {
type = bool
description = "Whether or not to enable expiration of manifest files."
default = false
}
1 change: 0 additions & 1 deletion terraform/staging_bucket.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ module "staging_dandiset_bucket" {
aws = aws
aws.project = aws
}
enable_manifest_file_expiration = true
}

module "staging_embargo_bucket" {
Expand Down
Loading