Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use version 0.25.5 of responses #1562

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Don't use version 0.25.5 of responses #1562

merged 1 commit into from
Jan 10, 2025

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jan 10, 2025

The latest release of responses somehow omitted its py.typed file, resulting in type-checking errors from projects that use it. [Bug report]

@jwodder jwodder added tests Add or improve existing tests dependencies Update one or more dependencies version labels Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (669b182) to head (896be17).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1562      +/-   ##
==========================================
- Coverage   88.48%   88.42%   -0.07%     
==========================================
  Files          78       78              
  Lines       10735    10735              
==========================================
- Hits         9499     9492       -7     
- Misses       1236     1243       +7     
Flag Coverage Δ
unittests 88.42% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

docs build is apparently not new and 4 last builds did fail and another one had similar fail, so unrelated to these changes somehow. Thank you @jwodder, let's proceed!

@yarikoptic yarikoptic merged commit 6d04829 into master Jan 10, 2025
23 of 26 checks passed
@yarikoptic yarikoptic deleted the skip-responses branch January 10, 2025 20:52
@yarikoptic yarikoptic mentioned this pull request Jan 10, 2025
1 task
Copy link

🚀 PR was released in 0.66.4 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants