Application::handleRequest now properly displays exceptions. #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Combined with Block8/b8framework#41 (on the 1.x version of the framework), this allows to gracefully handle "not found" exceptions. |
| } catch (\Exception $ex) { | ||
| $this->config->set('page_title', 'Error'); | ||
|
|
||
| $view = new View('exception'); | ||
| $view->exception = $ex; | ||
|
|
||
| $this->response->setResponseCode(500); | ||
| $this->response->setResponseCode($ex instanceof HttpException ? $ex->getErrorCode() : 500); |
There was a problem hiding this comment.
I'm not sure have a condition check here is good.
There was a problem hiding this comment.
This is the only differences between the two catch blocks. If HttpException used/overrode Exception::getCode instead of defining its own getErrorCode, this checks wouldn't even be necessary.
|
|
||
| $view = new View('exception'); | ||
| $view->exception = $ex; | ||
| return $this->respone; |
There was a problem hiding this comment.
Typo, should be $this->response(missing S)
mavimo
added
bug:b8framework
flag:ready-to-merge
and removed
flag:requires-changes
labels
|
This should not merge since the b8 framework fix was added. |
|
The PR fixes all exception handling on its own; it doesn't depend on the b8framework PR, which just sends a proper 404 HttpException instead of a PHP error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Type: bug fix
Primary Area: front-end
Link to Bug: #960, #929, #719.
Description of change: properly display exceptions happening while handling a request.
Description of solution: modified Application::handleRequest.