Fix for #60 and #61 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI cannot build the docker image for armv7, I'm looking to reproduce it on my local machine. |
|
I'm gonna merge this as I'm not able to test armv7 at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
chmod +xto Dockerfile, to make sure the exporter binary is always executable regardless of which permissions it may have on the host system.Not really important but added a
make promu-buildcommand to alias the promu build command just to try to keep everything inside the makefile and not have to remember the promu build exact commandFixed missing log messages when requests are successful but return a non 200 status code and adjusted the wording around each log message to be more unique and easy to relate where the errors are actually coming from.
Later I may look at the other issues you have here and may refactor a bit around the error messages.