Fix TorqDerate and CAN3Speed enum definitions #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TorqDerate spot value does not display properly in the esp8266-web-interface. With a TorqDerate of 13 it displays UDClimHigh. The problem is due to "+" being an invalid character for enum value names. As the field is used as a bitfield change the definition to a bitfield enum which the web interface can display. Verify behaviour with power-of-two values and mix of values between 0 and 31. Refix punctuation of CAN3Speed enum to allow it to be parsed by openinverter-can-tool
|
Did you test these changes work as they should? |
|
Yup. Hence the detail on how and what I tested it in the commit. |
Thanks, it was not clear is if "tests" mean test ran or tests to be ran. |
|
Sorry. I only ever list the developer tests I have actually run with details of the HW and SW I used in my commits. This information is the sort of thing expected by larger projects and something I thought would be useful to reviewers of my OI PRs. |
damienmaguire
approved these changes
Dec 5, 2024
|
Thanks Dave |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TorqDerate spot value does not display properly in the esp8266-web-interface. With a TorqDerate of 13 it displays UDClimHigh. The problem is due to "+" being an invalid character for enum value names. As the field is used as a bitfield change the definition to a bitfield enum which the web interface can display. Verify behaviour with power-of-two values and mix of values between 0 and 31.
Refix punctuation of CAN3Speed enum to allow it to be parsed by openinverter-can-tool
Tests: