This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Issue 336: Upgrade to PHP 8.1 #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
damien-carcel
force-pushed
the
issue-336
branch
from
58ceefa
to
6add214
Compare
damien-carcel
force-pushed
the
issue-336
branch
3 times, most recently
from
5e819c0
to
cb52947
Compare
damien-carcel
force-pushed
the
issue-336
branch
from
cb52947
to
fea49fc
Compare
- Remove "akeneo/php-coupling-detector" (to add again once it is PHP 8.1 compatible) - Replace PHPSpec by PHPUnit for unit tests
damien-carcel
force-pushed
the
issue-336
branch
from
fea49fc
to
3a941b5
Compare
|
| Secret | Commit | Filename | Detected At | |
|---|---|---|---|---|
| Generic High Entropy Secret | 3a941b5 | api/.env | 14:00 January 26th, 2022 | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.
Our GitHub checks need improvements? Share your feedbacks
damien-carcel
force-pushed
the
issue-336
branch
2 times, most recently
from
7e606c6
to
b3bd207
Compare
damien-carcel
force-pushed
the
issue-336
branch
from
b3bd207
to
1b14347
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to wait for a few dependencies (mostly the same as for Symfony 6).