Keep focused line on top of processes table when query is wrapped #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scrolling through processes and the query is wrapped, there is no way to compute an offset for the table rows in order to move the cursor. Instead, when query is wrapped, we now always display focused process on top of the table and we wrap around the processes list (display first processes at the end of the table).
|
Cool, I like it. |
blogh
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative proposal to #257 which (in my opinion) produces a less strange behavior.
When scrolling through processes and the query is wrapped, there is no
way to compute an offset for the table rows in order to move the cursor.
Instead, when query is wrapped, we now always display focused process on
top of the table and we wrap around the processes list (display first
processes at the end of the table).
@blogh, what do you think?