Fix scrolling issues #247
Merged
Fix scrolling issues #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dlax : this is far from finished but to you see a problem with how I handled scrolling ? |
|
I'd suggest to only fix one problem per PR; i.e. avoid header refresh in interactive mode. |
|
thx for the input. will do when it's no longer "experimental" |
blogh
force-pushed
the
fix_scrolling_issues
branch
from
1326ef5 to
a90a520
Compare
|
The refresh while pause thing was pushed in #248. |
blogh
commented
Oct 18, 2021
dlax
reviewed
Oct 18, 2021
|
Will add / fix tests later. |
dlax
reviewed
Oct 19, 2021
dlax
reviewed
Oct 19, 2021
|
Also, if you could write a more informative commit message than "Handle scrolling", that'd be great! |
blogh
force-pushed
the
fix_scrolling_issues
branch
3 times, most recently
from
6270d09 to
e67cf4c
Compare
dlax
reviewed
Oct 19, 2021
dlax
reviewed
Oct 20, 2021
blogh
force-pushed
the
fix_scrolling_issues
branch
from
e67cf4c to
e07ce46
Compare
When the line count overflows outside the screen, we can now properly scroll down. If the focus reaches 4/5 of the available lines on screen, the first line is removed and we display a new line at the bottom. When we reach the last line, pressing down will focus on the fist line again. Likewise, if the up key is pressed when the focus is on the first line, we focus on the last one.
blogh
force-pushed
the
fix_scrolling_issues
branch
from
e07ce46 to
3d5d172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR aims to solve some problems related to scrolling (#239)