curve: partial precomputation #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
changed the title
AaronFeickert
force-pushed
the
partial-precomputation
branch
from
73bb65e
to
cf43e06
Compare
AaronFeickert
force-pushed
the
partial-precomputation
branch
from
cf43e06
to
f937005
Compare
AaronFeickert
force-pushed
the
partial-precomputation
branch
from
f937005
to
99da7de
Compare
|
Very nice! New code and docs look great. Anything else needed @tarcieri ? |
tarcieri
approved these changes
Jul 30, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be useful to support multiscalar multiplication evaluation using partial precomputation, where a larger set of precomputation tables is generated than is needed for an evaluation.
This PR adds such functionality with minimal impact. Specifically, it does so by relaxing the panic conditions on the relevant
VartimePrecomputedMultiscalarMulfunctions (and their corresponding implementations). It also adds tests and updates the documentation carefully.Note that this is an improved version of #546, which was closed due to repository reorganization.