Cleanup hw #646
Closed
Cleanup hw #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...unsuccessful tho. Rust features are hard.
catch the case that the 14th limb overflows into the 15th at the final carry propagate step
it doesn't happen, i think there is a property of the math that makes us safe but i can't reason about what it is.
a simple loop that does factorial.
hacky implementation, but it'll let us do a performance benchmark
Note: breaks for anyone's build environment but mine!
builds clealy as a test crate, without any dependency on xous proper for configurations that don't involve xous.
minimizing the mount of data movement speeds up operations by about 2x
thanks @xobs for the work-around!
remove const generics so we don't affect their mininum rust version requirement
porting this in a manner similar to that used by the sha2 crate, removing the explicit Xous dependency link. see PR for discussion of issues
and also make the internal functions use the same conventions
This function should be able to be enabled by feature selection.
Update to v4 WIP
needed for software fallback
this will trigger software fallback
this falls back to fiat-crypto primitives if the hw engine is unavailable.
|
ugh sorry, github defaults to your main branch when I try to make a pull request to my own fork, and I keep forgetting to set the pulldown to my own fork. Sorry about the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches related to betrusted-io/xous-core#516