Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curve25519: Remove build-dep:platforms in favor of CARGO_CFG_TARGET_POINTER_WIDTH #636

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

pinkforest
Copy link
Contributor

@pinkforest pinkforest commented Feb 26, 2024

Fixes #610
Nightly CI depends on #638 nightly lint fix

Removes platform dep in favor of using CARGO_CFG_TARGET_POINTER_WIDTH

Left a note to make sure matching target platforms via type in future - there are build test/s in any case so 🤷‍♀️

@rozbb
Copy link
Contributor

rozbb commented Mar 1, 2024

You should be able to rebase on main now

@pinkforest
Copy link
Contributor Author

We're green 🥳 🎉 😅

@rozbb rozbb merged commit 31ccb67 into dalek-cryptography:main Mar 1, 2024
22 checks passed
@rozbb
Copy link
Contributor

rozbb commented Mar 1, 2024

More consistency via fewer deps. Love it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pointer width detection in build.rs may break for obscure platforms
2 participants