Skip to content

Commit

Permalink
Enable unexpected cfgs lint (#656)
Browse files Browse the repository at this point in the history
Previously, the only way to configure this lint was using a build.rs
file, but now it can be done using Cargo.toml as well.
  • Loading branch information
simonwuelker authored Jul 26, 2024
1 parent 921bd7c commit 35e78b2
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
10 changes: 10 additions & 0 deletions curve25519-dalek/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,13 @@ group-bits = ["group", "ff/bits"]

[target.'cfg(all(not(curve25519_dalek_backend = "fiat"), not(curve25519_dalek_backend = "serial"), target_arch = "x86_64"))'.dependencies]
curve25519-dalek-derive = { version = "0.1", path = "../curve25519-dalek-derive" }

[lints.rust.unexpected_cfgs]
level = "warn"
check-cfg = [
'cfg(allow_unused_unsafe)',
'cfg(curve25519_dalek_backend, values("fiat", "serial", "simd"))',
'cfg(curve25519_dalek_diagnostics, values("build"))',
'cfg(curve25519_dalek_bits, values("32", "64"))',
'cfg(nightly)',
]
2 changes: 1 addition & 1 deletion curve25519-dalek/src/backend/vector/ifma/edwards.rs
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ impl<'a> From<&'a edwards::EdwardsPoint> for NafLookupTable8<CachedPoint> {
}
}

#[cfg(target_feature = "avx512ifma,avx512vl")]
#[cfg(all(target_feature = "avx512ifma", target_feature = "avx512vl"))]
#[cfg(test)]
mod test {
use super::*;
Expand Down
2 changes: 1 addition & 1 deletion curve25519-dalek/src/backend/vector/ifma/field.rs
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ impl<'a, 'b> Mul<&'b F51x4Reduced> for &'a F51x4Reduced {
}
}

#[cfg(target_feature = "avx512ifma,avx512vl")]
#[cfg(all(target_feature = "avx512ifma", target_feature = "avx512vl"))]
#[cfg(test)]
mod test {
use super::*;
Expand Down
2 changes: 0 additions & 2 deletions curve25519-dalek/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@
unused_lifetimes,
unused_qualifications
)]
// Requires MSRV 1.77 as it does not allow build.rs gating
#![allow(unexpected_cfgs)]

//------------------------------------------------------------------------
// External dependencies:
Expand Down

0 comments on commit 35e78b2

Please sign in to comment.