Set the gain value on connect and display it in the setup window

daleghent · Oct 31, 2024 · 0de669d · 0de669d
1 parent d7d297f
commit 0de669d
Showing 1 changed file with 25 additions and 4 deletions.
diff --git a/src/cam_qhy.cpp b/src/cam_qhy.cpp
@@ -61,7 +61,9 @@ class Camera_QHY : public GuideCamera
 {
     qhyccd_handle *m_camhandle;
 
-    int m_curGain;
+    int m_curGain; // gain in percent of camera's maximum gain value
+
+    double m_curGainValue;
     double m_gainMin;
     double m_gainMax;
     double m_gainStep;
@@ -119,6 +121,7 @@ class Camera_QHY : public GuideCamera
     bool SetCoolerSetpoint(double temperature) override;
 
 protected:
+    uint32_t GetQhyGain();
     bool SetQhyGain(int gainPercent);
     bool SetQhyOffset(int offset);
     bool SetQhyUsbTraffic(int usbTraffic);
@@ -294,6 +297,7 @@ struct QHYCameraDlg : public wxDialog
 {
     wxRadioButton *m_bpp8;
     wxRadioButton *m_bpp16;
+    wxStaticText *m_gainText;
     wxSpinCtrl *m_offsetSpinner;
     wxSpinCtrl *m_usbTrafficSpinner;
     wxCheckBox *m_ampnrCb;
@@ -326,12 +330,17 @@ QHYCameraDlg::QHYCameraDlg() : wxDialog(wxGetApp().GetTopWindow(), wxID_ANY, _("
     wxStaticBoxSizer *cameraOptionsSizer = new wxStaticBoxSizer(new wxStaticBox(this, wxID_ANY, _("Camera Options")), wxVERTICAL);
     wxFlexGridSizer *optionsGrid = new wxFlexGridSizer(2, 5, 5);
 
+    m_gainText = new wxStaticText(this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxDefaultSize, 0);
+    m_gainText->SetToolTip(_("The actual gain level the camera is operating at. Gain level is set as a percentage of the camera's maximum possible gain level in Advanced Settings > Camera > Camera gain. Knowing the gain assists in setting the offset value."));
+
+    cameraOptionsSizer->Add(m_gainText, 0, wxALL, 5);
+
     m_offsetSpinner = NewSpinnerInt(this, pFrame->GetTextExtent("999"),
-                                    pConfig->Profile.GetInt(CONFIG_PATH_QHY_OFFSET, DEFAULT_OFFSET), 0, 1000, 1, "");
+                        pConfig->Profile.GetInt(CONFIG_PATH_QHY_OFFSET, DEFAULT_OFFSET), 0, 1000, 1, wxEmptyString);
     AddTableEntryPair(this, optionsGrid, _("Offset"), m_offsetSpinner);
 
     m_usbTrafficSpinner = NewSpinnerInt(this, pFrame->GetTextExtent("999"),
-                                    pConfig->Profile.GetDouble(CONFIG_PATH_QHY_USBTRAFFIC, DEFAULT_USBTRAFFIC), 0, 1000, 1,"");
+                        pConfig->Profile.GetDouble(CONFIG_PATH_QHY_USBTRAFFIC, DEFAULT_USBTRAFFIC), 0, 1000, 1, wxEmptyString);
     AddTableEntryPair(this, optionsGrid, _("USB Traffic"), m_usbTrafficSpinner);
 
     cameraOptionsSizer->Add(optionsGrid, 1, wxEXPAND, 5);
@@ -375,6 +384,8 @@ void Camera_QHY::ShowPropertyDialog()
         else
             dlg.m_bpp16->SetValue(true);
 
+        dlg.m_gainText->SetLabel(wxString::Format("Gain: %d (min: %g, max: %g)", GetQhyGain(), m_gainMin, m_gainMax));
+
         m_offset = pConfig->Profile.GetInt(CONFIG_PATH_QHY_OFFSET, DEFAULT_OFFSET);
         dlg.m_offsetSpinner->SetValue(m_offset);
         dlg.m_offsetSpinner->SetRange(m_offsetMin, m_offsetMax);
@@ -577,7 +588,12 @@ bool Camera_QHY::Connect(const wxString& camId)
     }
 
     ret = GetQHYCCDParamMinMaxStep(m_camhandle, CONTROL_GAIN, &m_gainMin, &m_gainMax, &m_gainStep);
-    if (ret != QHYCCD_SUCCESS)
+    if (ret == QHYCCD_SUCCESS)
+    {
+        m_curGain = GuideCameraGain;
+        SetQhyGain(m_curGain);
+    }
+    else
     {
         CloseQHYCCD(m_camhandle);
         m_camhandle = 0;
@@ -1083,6 +1099,11 @@ bool Camera_QHY::Capture(int duration, usImage& img, int options, const wxRect&
     return false;
 }
 
+uint32_t Camera_QHY::GetQhyGain()
+{
+    return (uint32_t)GetQHYCCDParam(m_camhandle, CONTROL_GAIN);
+}
+
 bool Camera_QHY::SetQhyGain(int gainPercent)
 {
     double gain = m_gainMin + gainPercent * (m_gainMax - m_gainMin) / 100.0;