-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use track-started and track-stopped #9
base: main
Are you sure you want to change the base?
Conversation
Hi, @jessmitch42! @philmillman mentioned that you might have some time tomorrow to revisit our original React demo refactoring. I hope this tag is okay! There are two main things I am struggling with:
I've tried, among other things:
If you have any ideas for managing the event bubbling (I was looking up stopPropagation for custom events), I'd appreciate it. And/or, if there's another direction to solve, or if there's a better way to approach from scratch (I'm currently storing a lot of screensharing state), I'm all ears. Thank you so much! |
Hi, @jessmitch42 and @kompfner! At long last, we've got a refactored version of the OG React demo that 1) Relies on For this intro demo that doesn't have toooo complicated of a state, I think this setup could be easier to follow for devs newer to Daily and newer devs in general (at least, it was for me). It closely mirrors our party-line pattern. I successfully tested:
When you have 20 minutes some time next week, I'd appreciate your feedback on:
Thank you! |
ETA: This is now ready for review (see comments below).