Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.1 #7

Merged
merged 2 commits into from
Aug 27, 2024
Merged

1.0.1 #7

merged 2 commits into from
Aug 27, 2024

Conversation

jamsea
Copy link
Contributor

@jamsea jamsea commented Aug 27, 2024 •
edited
Loading

Fixes #4
Fixes #5

@jamsea
Copy link
Contributor Author

jamsea commented Aug 27, 2024

Fixes #5

@jamsea
1.0.1
46c582d 
Rever gemfile

Fix lockfile

Update Gemfile

Generate again?

Fix generation bug

Remove test

Update example

Update example
@DominicStewart DominicStewart self-requested a review August 27, 2024 10:20
DominicStewart
DominicStewart approved these changes Aug 27, 2024
View reviewed changes
Copy link

@DominicStewart DominicStewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamsea jamsea merged commit a59ecf4 into main Aug 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominicStewart DominicStewart DominicStewart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Room Api PIN Number Create Room Example Doesn't Include Options
2 participants
@jamsea @DominicStewart