Skip to content

EE-2019.11.01: Issue 629 - Don't timeout connections while waiting for auth (#37)

Compare
Choose a tag to compare
@daid-tinyci daid-tinyci released this 01 Nov 19:22
· 558 commits to master since this release
Previously, during server auth, there are no packets sent back and forth between the client and server, which causes the client to timeout after 20 seconds (assuming this is in case the server has shutdown/crashed/etc). As reported in issue 629, this may not be long enough. I ended up tracing this issue back to the how the server sends CMD_ALIVE packets every 10 seconds through sendAll which only sends to authenticated clients. So I created a new keepAliveAll() which sends a CMD_ALIVE packet to all cients regardless of auth state. In addition, I added in logic to calculate the ClientInfo's ping. I didn't add any logic to do anything with the ping.