feat: inline credentials support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Wilcsinszky <[email protected]>
|
@daichirata friendly ping so that you might take a short look in case you have missed this. Please just let me know if it makes sense or not, thanks a lot! |
|
@pepov Sorry for the delay in replying. Thank you regarding the correction! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this patch in the https://github.com/kube-logging/logging-operator through the https://github.com/kube-logging/fluentd-images where we refer to a fork https://github.com/kube-logging/fluent-plugin-gcs that contains this change.
This PR would make that fork obsolete and we could depend on the gem directly.