Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] - Add deploymentStrategy to user deployment helm chart #26716

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marijncv
Copy link
Contributor

Summary & Motivation

Closes #26445

How I Tested These Changes

Added a test and ran helm template on a values file like:

deployments:
  - name: "k8s-example-user-code-1"
    image:
      repository: "docker.io/dagster/user-code-example"
      tag: ~
      pullPolicy: Always
    dagsterApiGrpcArgs:
      - "-f"
      - "/example_project/example_repo/repo.py"
    port: 3030
    deploymentStrategy:
      type: Recreate

@ion-elgreco
Copy link
Contributor

ion-elgreco commented Dec 27, 2024

This is very useful! This change would simplify our dagster user code deployment cli

@gibsondan
Copy link
Member

Hi @marijncv , thanks for sending this out. This looks good to me but it looks like it may need a rebase first due to some conflicts.

@gibsondan
Copy link
Member

(apologies for the delay, I imagine those conflicts are new since you first sent this out)

@marijncv
Copy link
Contributor Author

@gibsondan no worries, should be fixed now!

@gibsondan
Copy link
Member

@marijncv something has gone a little strange with the rebase here I think in a way that is confusing our CI - it looks like this PR is currently trying to do a third merge commit on top of your original two changes, but I think you want to rebase so that you're only trying to merge two commits into the current mas ter.

@gibsondan
Copy link
Member

here's an example external PR where the commits are lined up correctly: #26893 (there's no additional merge PR if you click on Commits, just the commits that are intended to merge into master)

If it's easier to just send our a new PR that would be fine too

@marijncv marijncv force-pushed the helm-add-deployment-strategy branch from 07a85c8 to 652c399 Compare January 11, 2025 07:33
@marijncv
Copy link
Contributor Author

@gibsondan ah my mistake. I tried to force push a rebase but it still seems to cause some issues in the CI so I created another PR here. Hope that one works and thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Chart: Add strategy for deployment type.
3 participants