[dagster-airlift] Handle run retries #25761
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
examples/experimental/dagster-airlift/dagster_airlift/in_airflow/dagster_run_utils.py
Outdated
Show resolved
Hide resolved
dpeng817
requested review from
alangenfeld,
benpankow and
schrockn
and removed request for
benpankow
gibsondan
reviewed
Nov 6, 2024
examples/experimental/dagster-airlift/dagster_airlift/in_airflow/dagster_run_utils.py
Outdated
Show resolved
Hide resolved
dpeng817
force-pushed
the
dpeng817/run_retries
branch
2 times, most recently
from
0db4861 to
4df8473
Compare
gibsondan
reviewed
Nov 6, 2024
examples/experimental/dagster-airlift/dagster_airlift/in_airflow/dagster_run_utils.py
Outdated
Show resolved
Hide resolved
gibsondan
reviewed
Nov 6, 2024
examples/experimental/dagster-airlift/dagster_airlift/in_airflow/dagster_run_utils.py
Outdated
Show resolved
Hide resolved
|
closing for now, will reopen when @jamiedemaria 's pr adding will_retry tag lands. |
dpeng817
force-pushed
the
dpeng817/run_retries
branch
from
4df8473 to
f205ca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Previously, when launching runs to a "migrated" asset, we would ignore run retries - so if the original run failed, regardless of whether a retry succeeded, we would fail the airflow run.
This PR fixes to correctly account for run retries in Dagster - by hooking into the retry machinery that @jamiedemaria built.
How I Tested These Changes
Adds a new test which simulates having auto-run-execution by using
materialize- and succeeding the last retry. Ensure that the airflow run succeeds, and the asset materializes eventually.The reason it's necessary to simulate auto-run-execution is because we use sqlite in tests as opposed to postgres - which we need in order to enable run retries.
I initially attempted to materialize assets inline within the body of the asset itself, but that seems to screw up some global context, so instead do it via graphql queries.
Changelog