[chore] unify local and pre-commit ruff configuration #23501
Merged
+73
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @danielgafni and the rest of your teammates on |
danielgafni
changed the title
danielgafni
force-pushed
the
08-08-unify_local_and_pre-commit_ruff_configuration
branch
from
0907f4c to
4f07ef5
Compare
alangenfeld
requested review from
rexledesma
and removed request for
alangenfeld
rexledesma
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
I don't use pre-commit anymore so I don't really have a strong opinion here. We could also consider just passing the pyproject.toml directly: astral-sh/ruff-pre-commit#54 (comment).
|
Should we get more approvals here or is it ok to merge? |
|
@rexledesma it will be picked up by |
danielgafni
force-pushed
the
08-08-unify_local_and_pre-commit_ruff_configuration
branch
from
4f07ef5 to
5d8d375
Compare
danielgafni
force-pushed
the
08-08-unify_local_and_pre-commit_ruff_configuration
branch
from
5d8d375 to
dc9b267
Compare
cmpadden
approved these changes
Aug 19, 2024
danielgafni
deleted the
08-08-unify_local_and_pre-commit_ruff_configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR makes
pre-commituse the sameruffsettings & executable as the local environment (e.g. when run viamake ruff).Should we add a
buildkitejob forpre-commit? Currently it's not being tested in CI.Context: https://dagsterlabs.slack.com/archives/C03A0D72A6T/p1723065934987029
How I Tested These Changes
pre-commitcan be enabled and doesn't produce any changes when runP.S. I had to add a few
= Noneplaceholders in some of the notebooks since previously these expressions lacked any assignment and were invalid (ruffwas failing completely on these files)