[Dagre bug workaround] Fallback to longest-path and network-simplex in asset graph in case of dagre bug #21157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b1d47e0. |
hellendag
approved these changes
Apr 11, 2024
yuhan
pushed a commit
that referenced
this pull request
Apr 11, 2024
…n asset graph in case of dagre bug (#21157) ## Summary & Motivation I was able to successfully render a buggy asset graph by falling all the way back to network-simplex, which is slow, but better than nothing. ## How I Tested These Changes Tested this with a customer's graph that is running into this issue
|
Ahhh this is a great fix, good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
dagrejs/dagre#234
I was able to successfully render a buggy asset graph by falling all the way back to network-simplex, which is slow, but better than nothing.
How I Tested These Changes
Tested this with a customer's graph that is running into this issue