-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Summary & Motivation Fixes this issue dagrejs/dagre#234 ## How I Tested These Changes I copied the JSON of a graph from a customer who was hitting this error and saw that the graph was able to correctly render with this patch.
- Loading branch information
Showing
4 changed files
with
137 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,8 @@ | |
| "post-build": "cd ../../python_modules/dagster-webserver/dagster_webserver && rm -rf webapp && mkdir -p webapp && cp -r ../../../js_modules/dagster-ui/packages/app-oss/build ./webapp/ && mkdir -p webapp/build/vendor && cp -r graphql-playground ./webapp/build/vendor && cp ../../../js_modules/dagster-ui/packages/app-oss/csp-header.txt ./webapp/build", | ||
| "lint": "yarn workspace @dagster-io/app-oss lint && yarn workspace @dagster-io/ui-core lint && yarn workspace @dagster-io/ui-components lint", | ||
| "start": "yarn workspace @dagster-io/app-oss start", | ||
| "ts": "yarn workspace @dagster-io/app-oss ts && yarn workspace @dagster-io/ui-components ts" | ||
| "ts": "yarn workspace @dagster-io/app-oss ts && yarn workspace @dagster-io/ui-components ts", | ||
| "postinstall": "patch-package" | ||
| }, | ||
| "workspaces": { | ||
| "packages": [ | ||
|
|
@@ -18,9 +19,12 @@ | |
| }, | ||
| "packageManager": "[email protected]", | ||
| "dependencies": { | ||
| "graphql.macro": "^1.4.2" | ||
| "graphql.macro": "^1.4.2", | ||
| "patch-package": "^8.0.0", | ||
| "postinstall-postinstall": "^2.1.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/dagre": "^0", | ||
| "file-loader": "^6.2.0" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| diff --git a/node_modules/dagre/lib/order/index.js b/node_modules/dagre/lib/order/index.js | ||
| index 4ac2d9f..a2182fe 100644 | ||
| --- a/node_modules/dagre/lib/order/index.js | ||
| +++ b/node_modules/dagre/lib/order/index.js | ||
| @@ -73,7 +73,9 @@ function sweepLayerGraphs(layerGraphs, biasRight) { | ||
| function assignOrder(g, layering) { | ||
| _.forEach(layering, function(layer) { | ||
| _.forEach(layer, function(v, i) { | ||
| - g.node(v).order = i; | ||
| + try { | ||
| + g.node(v).order = i; | ||
| + } catch (e) {} | ||
| }); | ||
| }); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
249b468There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-6i9lxw17v-elementl.vercel.app
Built with commit 249b468.
This pull request is being automatically deployed with vercel-action