Add Chroma Resource #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpeng817
approved these changes
Jan 13, 2025
libraries/dagster-contrib-chroma/dagster_contrib_chroma/resource.py
Outdated
Show resolved
Hide resolved
libraries/dagster-contrib-chroma/dagster_contrib_chroma/resource.py
Outdated
Show resolved
Hide resolved
|
Shortened the documentation - let me know what you think @dpeng817 |
dpeng817
reviewed
Jan 14, 2025
Comment on lines
37
to
42
| "chroma_local": ChromaResource( | ||
| connection_config=LocalConfig(persistence_path="./chroma") | ||
| ), | ||
| "chroma_http": ChromaResource( | ||
| connection_config=HttpConfig(host="localhost", port=8000) | ||
| ) |
There was a problem hiding this comment.
this isn't exactly what I meant; I think a user would probably want to be able to switch configurations without switching resource keys. I meant something like this:
"chroma": ChromaResource(
connection_config=LocalConfig(...) if not os.getenv("USE_CONN") else HttpConfig(...)
)There was a problem hiding this comment.
Updated - how about this option? @dpeng817
shimon-cherrypick
force-pushed
the
chroma
branch
from
f3cc8cd to
b22fb1f
Compare
|
Okay looks totally good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog
Ensure that an entry has been created in
CHANGELOG.mdoutlining additions, deletions, and/or modifications.See: keepachangelog.com