Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-notdiamond] rename dagster-contrib-notdiamond to dagster-notdiamond #108

Merged
merged 1 commit into from
Feb 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .github/workflows/quality-check-dagster-contrib-notdiamond.yml

This file was deleted.

12 changes: 12 additions & 0 deletions .github/workflows/quality-check-dagster-notdiamond.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: quality-check-dagster-notdiamond
on:
pull_request:
types: [opened, synchronize, reopened]
paths:
- 'libraries/dagster-notdiamond/**'

jobs:
check:
uses: ./.github/workflows/template-quality-check.yml
with:
working_directory: ./libraries/dagster-notdiamond
Dismissed Show dismissed Hide dismissed
14 changes: 0 additions & 14 deletions .github/workflows/release-dagster-contrib-notdiamond.yml

This file was deleted.

14 changes: 14 additions & 0 deletions .github/workflows/release-dagster-notdiamond.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: build-and-release-dagster-notdiamond

on:
push:
tags:
- 'dagster_notdiamond-*.*.*'

jobs:
build-and-release-dagster-notdiamond:
uses: ./.github/workflows/template-release.yml
with:
library_name: dagster-notdiamond
working_directory: ./libraries/dagster-notdiamond
secrets: inherit
Dismissed Show dismissed Hide dismissed

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Not Diamond is an AI model router that automatically determines which LLM is bes
## Installation

```bash
pip install dagster-contrib-notdiamond
pip install dagster-notdiamond
```

## Configuration
Expand All @@ -26,7 +26,7 @@ from dagster import (
MaterializeResult,
asset,
)
from dagster_contrib_notdiamond import NotDiamondResource
from dagster_notdiamond import NotDiamondResource


@asset
Expand Down Expand Up @@ -59,7 +59,7 @@ your pyproject.toml as follows (replacing `$PROJECT_HOME` with the path to this
```toml
[tool.dagster]
module_name = "examples.example_notdiamond"
working_directory = "$PROJECT_HOME/libraries/dagster-contrib-notdiamond/"
working_directory = "$PROJECT_HOME/libraries/dagster-notdiamond/"
```

## Support
Expand Down
3 changes: 3 additions & 0 deletions libraries/dagster-notdiamond/dagster_notdiamond/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from dagster_notdiamond.resources import (
NotDiamondResource as NotDiamondResource,
)
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class NotDiamondResource(ConfigurableResource):
MaterializeResult,
asset,
)
from dagster_contrib_notdiamond import NotDiamondResource
from dagster_notdiamond import NotDiamondResource


@asset
Expand Down Expand Up @@ -88,7 +88,7 @@ def setup_for_execution(self, context: InitResourceContext) -> None:
# Set up a Not Diamond client based on the API key.
self._client = NotDiamond(
api_key=self.api_key,
user_agent=f"dagster-contrib-notdiamond/{metadata.version('dagster-contrib-notdiamond')}",
user_agent=f"dagster-notdiamond/{metadata.version('dagster-notdiamond')}",
)

@public
Expand All @@ -110,7 +110,7 @@ def get_client(
.. code-block:: python

from dagster import AssetExecutionContext, asset
from dagster_contrib_notdiamond import NotDiamondResource
from dagster_notdiamond import NotDiamondResource

@asset(compute_kind="NotDiamond")
def notdiamond_asset(context: AssetExecutionContext, notdiamond: NotDiamondResource) -> Tuple[str, str]:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@
from dagster._core.errors import DagsterInvariantViolationError
from dagster._core.execution.context.init import build_init_resource_context
from dagster._utils.test import wrap_op_in_graph_and_execute
from dagster_contrib_notdiamond import NotDiamondResource
from dagster_notdiamond import NotDiamondResource
from unittest.mock import ANY, MagicMock, patch


@patch("dagster_contrib_notdiamond.resources.NotDiamond")
@patch("dagster_notdiamond.resources.NotDiamond")
def test_notdiamond_client(mock_client) -> None:
notdiamond_resource = NotDiamondResource(
api_key="xoxp-1234123412341234-12341234-1234"
Expand All @@ -35,7 +35,7 @@ def test_notdiamond_client(mock_client) -> None:
)


@patch("dagster_contrib_notdiamond.resources.NotDiamond")
@patch("dagster_notdiamond.resources.NotDiamond")
def test_notdiamond_client_with_config(mock_client) -> None:
notdiamond_resource = NotDiamondResource(
api_key="xoxp-1234123412341234-12341234-1234",
Expand All @@ -50,7 +50,7 @@ def test_notdiamond_client_with_config(mock_client) -> None:


@patch("dagster.OpExecutionContext", autospec=OpExecutionContext)
@patch("dagster_contrib_notdiamond.resources.NotDiamond")
@patch("dagster_notdiamond.resources.NotDiamond")
def test_notdiamond_resource_with_op(mock_client, mock_context):
@op
def notdiamond_op(notdiamond_resource: NotDiamondResource):
Expand All @@ -76,7 +76,7 @@ def notdiamond_op(notdiamond_resource: NotDiamondResource):


@patch("dagster.AssetExecutionContext", autospec=AssetExecutionContext)
@patch("dagster_contrib_notdiamond.resources.NotDiamond")
@patch("dagster_notdiamond.resources.NotDiamond")
def test_notdiamond_resource_with_asset(mock_client, mock_context):
@asset
def notdiamond_asset(notdiamond_resource: NotDiamondResource):
Expand All @@ -103,7 +103,7 @@ def notdiamond_asset(notdiamond_resource: NotDiamondResource):


@patch("dagster.AssetExecutionContext", autospec=AssetExecutionContext)
@patch("dagster_contrib_notdiamond.resources.NotDiamond")
@patch("dagster_notdiamond.resources.NotDiamond")
def test_notdiamond_resource_with_graph_backed_asset(mock_client, mock_context):
@op
def model_version_op():
Expand Down Expand Up @@ -139,7 +139,7 @@ def notdiamond_asset():


@patch("dagster.AssetExecutionContext", autospec=AssetExecutionContext)
@patch("dagster_contrib_notdiamond.resources.NotDiamond")
@patch("dagster_notdiamond.resources.NotDiamond")
def test_notdiamond_resource_with_multi_asset(mock_client, mock_context):
@multi_asset(
specs=[AssetSpec("status"), AssetSpec("result")],
Expand Down Expand Up @@ -186,7 +186,7 @@ def notdiamond_multi_asset(notdiamond_resource: NotDiamondResource):


@patch("dagster.AssetExecutionContext", autospec=AssetExecutionContext)
@patch("dagster_contrib_notdiamond.resources.NotDiamond")
@patch("dagster_notdiamond.resources.NotDiamond")
def test_notdiamond_resource_with_partitioned_asset(mock_client, mock_context):
notdiamond_partitions_def = StaticPartitionsDefinition([str(j) for j in range(5)])

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import time

import dagster as dg
import dagster_contrib_notdiamond as nd
import dagster_notdiamond as nd
import dagster_openai as oai


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
MaterializeResult,
asset,
)
from dagster_contrib_notdiamond import NotDiamondResource
from dagster_notdiamond import NotDiamondResource


@asset
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[project]
name = "dagster-contrib-notdiamond"
name = "dagster-notdiamond"
version = "0.1.2"
description = "Dagster integration with Not Diamond"
readme = "README.md"
Expand All @@ -23,4 +23,4 @@ requires = ["setuptools>=42"]
build-backend = "setuptools.build_meta"

[tool.setuptools]
packages = ["dagster_contrib_notdiamond"]
packages = ["dagster_notdiamond"]

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.