Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiline output #163

Merged
merged 3 commits into from
Nov 11, 2024
Merged

fix: multiline output #163

merged 3 commits into from
Nov 11, 2024

Conversation

jedevc
Copy link
Member

@jedevc jedevc commented Nov 11, 2024

Fixes #161, a regression introduced in 1a00b8f (#153).

@jedevc jedevc force-pushed the fix-multiline-output branch 5 times, most recently from 738d572 to 0ed89c2 Compare November 11, 2024 17:14
echo "stdout<<${delim}"
cat "${tmpout}"
echo
echo "${delim}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is very creative

Copy link
Member Author

@jedevc jedevc Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😜 hehe ye, better suggestions appreciated if you have them, I didn't want to use a fixed EOF string on the off chance that that appeared in the output.

@jedevc jedevc marked this pull request as ready for review November 11, 2024 17:33
Signed-off-by: Justin Chadwell <[email protected]>
@jedevc jedevc force-pushed the fix-multiline-output branch from 0ed89c2 to 48b2578 Compare November 11, 2024 17:40
Signed-off-by: Justin Chadwell <[email protected]>
@jedevc jedevc force-pushed the fix-multiline-output branch from 48b2578 to 9968d42 Compare November 11, 2024 17:47
@jedevc
Copy link
Member Author

jedevc commented Nov 11, 2024

FYI @kpenfound added a commit at the end that fixes #162.

Noticed there was a bug that caused quotes in args/call to not quite work as expected, they were getting incorrectly expanded. So just fell back to the old behavior, and handled the replacement in github action expressions.

Copy link
Contributor

@kpenfound kpenfound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@jedevc jedevc merged commit e5153f5 into dagger:main Nov 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Error running module with multiline output
2 participants