Make sure FancyReporter detects encoding of the traceback messages. #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dag,
I'm going to use Attest==0.5.3 instead of Unittest for my project focused on Korean language. So my test suites contain many Hangul characters (non-ASCII) and are hinted encoding by
# -*- coding: utf-8 -*-
. But traceback message of FancyReporter is broken because it doesn't aware the encoding of the test code.The output will be broken:
My patch provides the code encoding detector for fix broken messages of FancyReporter:
Please review and accept this pull request if there's no problem.
Regards,
Heungsub