This repository has been archived by the owner on Nov 15, 2024. It is now read-only.
Sourcery refactored master branch #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-45
to
+55
| # r1 and s1 are contained in this ECDSA signature encoded in DER (openssl default). | ||
| der_sig1 = "3044" | ||
| der_sig1 += "0220d47ce4c025c35ec440bc81d99834a624875161a26bf56ef7fdc0f5d52f843ad1" | ||
| der_sig1 = ( | ||
| "3044" | ||
| + "0220d47ce4c025c35ec440bc81d99834a624875161a26bf56ef7fdc0f5d52f843ad1" | ||
| ) | ||
| der_sig1 += "022044e1ff2dfd8102cf7a47c21d5c9fd5701610d04953c6836596b4fe9dd2f53e3e" | ||
| der_sig1 += "01" | ||
|
|
||
| # the same thing with the above line. | ||
| der_sig2 = "3044" | ||
| der_sig2 += "0220d47ce4c025c35ec440bc81d99834a624875161a26bf56ef7fdc0f5d52f843ad1" | ||
| der_sig2 = ( | ||
| "3044" | ||
| + "0220d47ce4c025c35ec440bc81d99834a624875161a26bf56ef7fdc0f5d52f843ad1" | ||
| ) |
There was a problem hiding this comment.
Lines 45-53 refactored with the following changes:
- Replace assignment and augmented assignment with single assignment [×2] (
merge-assign-and-aug-assign)
This removes the following comments ( why? ):
# the same thing with the above line.
# r1 and s1 are contained in this ECDSA signature encoded in DER (openssl default).
Comment on lines
-78
to
+81
| a = "0" + a | ||
| res = base58_encode(int("0x" + a, 16)) | ||
| a = f"0{a}" | ||
| res = base58_encode(int(f"0x{a}", 16)) |
There was a problem hiding this comment.
Function base58_encode_padded refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Comment on lines
-102
to
+104
| string = binary[i + 2 : end] | ||
| return string | ||
| return binary[i + 2 : end] |
There was a problem hiding this comment.
Function py2_get_der_field refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-112
to
+113
| string = binary[i + 2 : end] | ||
| return string | ||
| return binary[i + 2 : end] |
There was a problem hiding this comment.
Function py3_get_der_field refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-122
to
+126
| if (full_length + 3) == len(binary): | ||
| r = py2_get_der_field(2, binary) | ||
| s = py2_get_der_field(len(r) + 4, binary) | ||
| return r, s | ||
| else: | ||
| if full_length + 3 != len(binary): | ||
| return None | ||
| r = py2_get_der_field(2, binary) | ||
| s = py2_get_der_field(len(r) + 4, binary) | ||
| return r, s |
There was a problem hiding this comment.
Function py2_der_decode refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
Comment on lines
-146
to
+148
| print("hexPrivkey = %s" % hexprivkey) | ||
| print(f"hexPrivkey = {hexprivkey}") | ||
| wif = base58_check_encode(binascii.unhexlify(hexprivkey), version=128) | ||
| print("bitcoin Privkey (WIF) = %s" % wif) | ||
| wif = base58_check_encode(binascii.unhexlify(hexprivkey + "01"), version=128) | ||
| print("bitcoin Privkey (WIF compressed) = %s" % wif) | ||
| print(f"bitcoin Privkey (WIF) = {wif}") | ||
| wif = base58_check_encode(binascii.unhexlify(f"{hexprivkey}01"), version=128) | ||
| print(f"bitcoin Privkey (WIF compressed) = {wif}") |
There was a problem hiding this comment.
Function show_results refactored with the following changes:
- Replace interpolated string formatting with f-string [×3] (
replace-interpolation-with-fstring) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-158
to
+156
| print("%s: %s" % (param, params[param])) | ||
| print(f"{param}: {params[param]}") |
There was a problem hiding this comment.
Function show_params refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring)
Comment on lines
-171
to
-173
| privkey = [] | ||
| privkey = [inverse_mult(((z1 * s2) - (z2 * s1)), (r * (s1 - s2)), p) % int(p)] | ||
|
|
||
| privkey.append((inverse_mult(((z1 * s2) - (z2 * s1)), (r * (s1 - s2)), p) % int(p))) |
There was a problem hiding this comment.
Function derivate_privkey refactored with the following changes:
- Merge append into list declaration (
merge-list-append)
Comment on lines
-199
to
+196
| privkey = [ | ||
| return [ |
There was a problem hiding this comment.
Function derivate_privkey_fast refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-243
to
+238
| privkey = derivate_privkey_fast(p, r1, s1, s2, z1, z2) | ||
| return privkey | ||
| return derivate_privkey_fast(p, r1, s1, s2, z1, z2) |
There was a problem hiding this comment.
Function process_signatures refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!