Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offchain DAOs on Etherlink #862

Merged
merged 30 commits into from
Nov 6, 2024
Merged

Offchain DAOs on Etherlink #862

merged 30 commits into from
Nov 6, 2024

Conversation

ashutoshpw
Copy link
Collaborator

@ashutoshpw ashutoshpw commented Jul 16, 2024

  • Implementing WAGMI for Etherlink Login
  • Moved network definitions to Constant file
  • Changing useTezos hook to handle login with Etherlink
  • Changing Validation options when Etherlink is active.
  • Show logged in user across the website
  • Deploy Offchain DAO Form

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for tezos-homebase ready!

Name Link
🔨 Latest commit 1a8fad6
🔍 Latest deploy log https://app.netlify.com/sites/tezos-homebase/deploys/672a605ab7a0790008403649
😎 Deploy Preview https://deploy-preview-862--tezos-homebase.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 30 (🔴 down 10 from production)
Accessibility: 86 (🔴 down 3 from production)
Best Practices: 100 (no change from production)
SEO: 58 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashutoshpw ashutoshpw changed the title WIP: Offchain DAOs on Etherlink Offchain DAOs on Etherlink Aug 19, 2024
@ashutoshpw ashutoshpw marked this pull request as ready for review August 19, 2024 21:15
@EightRice EightRice removed their request for review August 28, 2024 10:30
@EightRice EightRice self-requested a review September 11, 2024 10:56
src/modules/common/ConnectWalletButton.tsx Outdated Show resolved Hide resolved
src/modules/common/ConnectWalletButton.tsx Outdated Show resolved Hide resolved
@@ -56,7 +51,7 @@ export const ChangeNetworkButton = () => {
<ColorDot color={networkDotColorMap[network]} />
</Grid>
<Grid item>
<Typography color="textSecondary">{capitalize(network)}</Typography>
<Typography color="textSecondary">{getNetworkDisplayName(network)}</Typography>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing network to etherlink issues

  • makes user "connect wallet" directly, should only switch network
  • Even on connecting network nothing happens (Connect wallet button doesn't changes)

@@ -56,7 +51,7 @@ export const ChangeNetworkButton = () => {
<ColorDot color={networkDotColorMap[network]} />
</Grid>
<Grid item>
<Typography color="textSecondary">{capitalize(network)}</Typography>
<Typography color="textSecondary">{getNetworkDisplayName(network)}</Typography>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Network switch doesn't work without refreshing the page.

@@ -56,7 +51,7 @@ export const ChangeNetworkButton = () => {
<ColorDot color={networkDotColorMap[network]} />
</Grid>
<Grid item>
<Typography color="textSecondary">{capitalize(network)}</Typography>
<Typography color="textSecondary">{getNetworkDisplayName(network)}</Typography>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Network switch should also switch network in EVM wallet.

Eg - So Basically if user clicks on Etherlink mainnet - The wallet should show modals to add etherlink mainnet and then swithc network to it both on dapp and wallet. This is a standard practice in web3 apps

Check the docs here - https://wagmi.sh/react/api/hooks/useSwitchChain#usage

src/modules/explorer/pages/ProposalDetails/index.tsx Outdated Show resolved Hide resolved
@@ -314,6 +314,9 @@ export const ProposalDetails: React.FC = () => {
}
}

console.log({ proposal })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-04 at 09 18 40

the decimal calculation is probably wrong.

@@ -387,8 +390,7 @@ export const ProposalDetails: React.FC = () => {
<Grid item>
<DescriptionText>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the token balance is incorrect. I have 50 eUSD in this dao but when i vote it's always with 1 eUSD

src/modules/creator/deployment/steps/Ownership.tsx Outdated Show resolved Hide resolved
// 2. Create wagmiConfig
const metadata = {
name: "Homebase",
description: "AppKit Example",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this example data will show up in mobile wallet

@ashutoshpw ashutoshpw self-assigned this Oct 1, 2024
@Man-Jain
Copy link
Collaborator

Man-Jain commented Oct 6, 2024

@ashutoshpw Are these comment still WIP or done ?

@ashutoshpw
Copy link
Collaborator Author

@Man-Jain This is still in WIP, I will re-request review once all the issues as fixed.

* WIP:
- Implementing WAGMI for Etherlink Login
- Changing useTezos hook to handle login with Etherlink
- Changing Validation options when Etherlink is active.

* WIP:

* WIP - Offchain DAO Almost Works.

* Token Deployer for Etherlink

* Updated changelog

* Fixes after Rebase
@EightRice EightRice removed the request for review from Man-Jain November 5, 2024 18:14
@EightRice EightRice merged commit 402a5b1 into master Nov 6, 2024
6 checks passed
@EightRice EightRice deleted the feat/offchain-dao-etherlink branch November 6, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants