-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offchain DAOs on Etherlink #862
Conversation
ashutoshpw
commented
Jul 16, 2024
•
edited
Loading
edited
- Implementing WAGMI for Etherlink Login
- Moved network definitions to Constant file
- Changing useTezos hook to handle login with Etherlink
- Changing Validation options when Etherlink is active.
- Show logged in user across the website
- Deploy Offchain DAO Form
✅ Deploy Preview for tezos-homebase ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -56,7 +51,7 @@ export const ChangeNetworkButton = () => { | |||
<ColorDot color={networkDotColorMap[network]} /> | |||
</Grid> | |||
<Grid item> | |||
<Typography color="textSecondary">{capitalize(network)}</Typography> | |||
<Typography color="textSecondary">{getNetworkDisplayName(network)}</Typography> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing network to etherlink issues
- makes user "connect wallet" directly, should only switch network
- Even on connecting network nothing happens (Connect wallet button doesn't changes)
@@ -56,7 +51,7 @@ export const ChangeNetworkButton = () => { | |||
<ColorDot color={networkDotColorMap[network]} /> | |||
</Grid> | |||
<Grid item> | |||
<Typography color="textSecondary">{capitalize(network)}</Typography> | |||
<Typography color="textSecondary">{getNetworkDisplayName(network)}</Typography> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Network switch doesn't work without refreshing the page.
@@ -56,7 +51,7 @@ export const ChangeNetworkButton = () => { | |||
<ColorDot color={networkDotColorMap[network]} /> | |||
</Grid> | |||
<Grid item> | |||
<Typography color="textSecondary">{capitalize(network)}</Typography> | |||
<Typography color="textSecondary">{getNetworkDisplayName(network)}</Typography> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Network switch should also switch network in EVM wallet.
Eg - So Basically if user clicks on Etherlink mainnet - The wallet should show modals to add etherlink mainnet and then swithc network to it both on dapp and wallet. This is a standard practice in web3 apps
Check the docs here - https://wagmi.sh/react/api/hooks/useSwitchChain#usage
@@ -314,6 +314,9 @@ export const ProposalDetails: React.FC = () => { | |||
} | |||
} | |||
|
|||
console.log({ proposal }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -387,8 +390,7 @@ export const ProposalDetails: React.FC = () => { | |||
<Grid item> | |||
<DescriptionText> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the token balance is incorrect. I have 50 eUSD in this dao but when i vote it's always with 1 eUSD
src/services/wagmi/config.ts
Outdated
// 2. Create wagmiConfig | ||
const metadata = { | ||
name: "Homebase", | ||
description: "AppKit Example", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix this example data will show up in mobile wallet
c9a581e
to
c40e6a9
Compare
@ashutoshpw Are these comment still WIP or done ? |
@Man-Jain This is still in WIP, I will re-request review once all the issues as fixed. |
* WIP: - Implementing WAGMI for Etherlink Login - Changing useTezos hook to handle login with Etherlink - Changing Validation options when Etherlink is active. * WIP: * WIP - Offchain DAO Almost Works. * Token Deployer for Etherlink * Updated changelog * Fixes after Rebase