Overhaul internal resource management #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4rken
added
enhancement
I just couldn't get rid of the race condition when starting/stopping the `shareIn` Flow
Fix race condition we new lease was not yet added, but leaseCheck ran and cancelled the sourceJob despite an ongoing get() call Simplify debug flags Refactor debug flags Fix test Fix flaky test New debug flags Improve debug output Further work on SharedResource + more tests Fixed race-conditions related to fast and short lifecycles get()+close() There might still be an issue related to addChild(...).close and InternalCancellationException being thrown? Fix null sourceValue being accessed on scope cancellation
d4rken
force-pushed
the
task-start-hanging
branch
from
fc3a54d to
70c8202
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rewrite of
SharedResource, which is a class that manages the lifecycle of costly dependencies. These costly services are mostly Root and ADB related (launching a service in an extra process and connecting to it).Replacing RXShell (#1529) made flaws within the old
SharedResourcevisible, where we could trigger a race condition if one consumer gets a new lease, while another closes the last one.I couldn't get the
Flow.shareInlogic (on which the oldSharedResourcewas based) to work. This is custom solution which gives me finer control over the behavior.This should get us