-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support no_std
#52
Open
TTWNO
wants to merge
6
commits into
d-e-s-o:main
Choose a base branch
from
TTWNO:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−6
Open
Support no_std
#52
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a4d5457
Use no_std compatible types
TTWNO b7306ef
Cargo format
TTWNO 1a56303
Add std features, enabled by default
TTWNO 2967440
Add no_std test, make 'log' depend on 'std'
TTWNO a738bd2
Add additional test step that tests the 'no_std_required' file
TTWNO a9bb05e
Rename test to match file
TTWNO File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,15 @@ | ||
// Copyright (C) 2019-2023 Daniel Mueller <[email protected]> | ||
// SPDX-License-Identifier: (Apache-2.0 OR MIT) | ||
|
||
#![no_std] | ||
|
||
extern crate alloc; | ||
extern crate proc_macro; | ||
|
||
use alloc::string::String; | ||
use alloc::vec; | ||
use alloc::vec::Vec; | ||
|
||
use proc_macro::TokenStream; | ||
use proc_macro2::TokenStream as Tokens; | ||
|
||
|
@@ -199,10 +206,8 @@ fn expand_tracing_init(attribute_args: &AttributeArgs) -> Tokens { | |
let __internal_event_filter = { | ||
use ::test_log::tracing_subscriber::fmt::format::FmtSpan; | ||
|
||
match ::std::env::var_os("RUST_LOG_SPAN_EVENTS") { | ||
match ::core::option_env!("RUST_LOG_SPAN_EVENTS") { | ||
Some(mut value) => { | ||
value.make_ascii_lowercase(); | ||
let value = value.to_str().expect("test-log: RUST_LOG_SPAN_EVENTS must be valid UTF-8"); | ||
Comment on lines
-204
to
-205
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar comment as above. |
||
value | ||
.split(",") | ||
.map(|filter| match filter.trim() { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should preserve the runtime behavior, at least for
std
contexts. Can you introduce anstd
feature and make this conditional?