Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciation warnining #161

Merged
merged 34 commits into from
Oct 15, 2024
Merged

Depreciation warnining #161

merged 34 commits into from
Oct 15, 2024

Conversation

tayllatheodoro
Copy link
Contributor

@tayllatheodoro tayllatheodoro commented Sep 20, 2024

The depreciation warning was added as a decorator before each function and class that are migrating to biahub.
To do:

  • Tests

Copy link
Collaborator

@ieivanov ieivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find that the warnings.warn() message is not issued on the terminal as click filters our these warnings. Instead of using warnings.warn() you should modify the click command decorator to @click.command(deprecated=True). I've tested that this does issue a warning. With this syntax, you don't have an option to add a custom message (e.g. Use the function in biahub), but I think that's OK.

pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@ieivanov ieivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the tests in test_analysis to a new PR in biahub. I think the tests in test_cli are good.

@ieivanov
Copy link
Collaborator

ieivanov commented Sep 30, 2024

I find that the warnings.warn() message is not issued on the terminal as click filters our these warnings. Instead of using warnings.warn() you should modify the click command decorator to @click.command(deprecated=True). I've tested that this does issue a warning. With this syntax, you don't have an option to add a custom message (e.g. Use the function in biahub), but I think that's OK.

@tayllatheodoro I think this comment is still not resolved. Once you've implemented the @click.command(deprecated=True) syntax I think we can merge this branch.

P.S. Also, you should pull main into this branch to resolve the merge conflicts.

@tayllatheodoro
Copy link
Contributor Author

deprecated=True

Hii, I had understood it was a suggestion, but I just corrected it. Thank you

@ieivanov ieivanov merged commit f110ae2 into main Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants