-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depreciation warnining #161
Conversation
…disply and sorting imports for style correction
…incompactability with click lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find that the warnings.warn()
message is not issued on the terminal as click
filters our these warnings. Instead of using warnings.warn()
you should modify the click command decorator to @click.command(deprecated=True)
. I've tested that this does issue a warning. With this syntax, you don't have an option to add a custom message (e.g. Use the function in biahub
), but I think that's OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move the tests in test_analysis
to a new PR in biahub
. I think the tests in test_cli
are good.
@tayllatheodoro I think this comment is still not resolved. Once you've implemented the P.S. Also, you should pull |
Hii, I had understood it was a suggestion, but I just corrected it. Thank you |
The depreciation warning was added as a decorator before each function and class that are migrating to biahub.
To do: