Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in parallelization over t and c #152

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Bug in parallelization over t and c #152

merged 2 commits into from
Jul 19, 2024

Conversation

edyoshikun
Copy link
Contributor

@edyoshikun edyoshikun commented Jul 16, 2024

This PR patches an the error in our function that parallelizes over t and c.

We haven't used this function in quite some time, but there were two bugs:

  • Bug in the partial function that is launched to parallelize over T and C.
  • Previously we used to computed everything on zyx, so this function required an update to handle czyx 4D volumes in order for these to still work (i.e copy_n_paste_czyx).

@edyoshikun edyoshikun requested a review from ieivanov July 16, 2024 00:09
@talonchandler talonchandler merged commit 0010fe7 into main Jul 19, 2024
2 checks passed
@ieivanov ieivanov deleted the fix_tc_parallel branch August 13, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants