Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support '@' symbols in resource names and vhosts #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

N3uR0TiCV0iD
Copy link

This PR addresses issue #33.

Problem:

The current method of parsing a resource id in the parseId function uses the "@" symbol as a delimiter.

This causes issues when either the name of the resource or the vhost contains "@" symbols, leading to incorrect splitting and an error to be raised.

Solution:

Implemented percent encoding for "@" symbols found in the name/vhost when combining them as a "composite resource id".

Then, during parsing, we split the resource id and then apply percent decoding to retrieve the correct values.

This approach ensures accurate parsing while being backward compatible with existing resource IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant