Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-14743: Fix repo level policy examples #605

Merged
merged 4 commits into from
Jan 7, 2025
Merged

ENG-14743: Fix repo level policy examples #605

merged 4 commits into from
Jan 7, 2025

Conversation

yoursnerdly
Copy link
Contributor

@yoursnerdly yoursnerdly commented Jan 6, 2025

Description of the change

Fix incorrect examples in the repo level policy guide.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

Manually inspected the generated docs in browser.

@yoursnerdly yoursnerdly requested a review from cyral-bot as a code owner January 6, 2025 21:02
Copy link
Contributor

@gengdahlCyral gengdahlCyral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Jan 7, 2025

@yoursnerdly yoursnerdly merged commit 89a4058 into main Jan 7, 2025
3 checks passed
@yoursnerdly yoursnerdly deleted the fix-examples branch January 7, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants