add comment about browser and quotes

cypress-io · Nov 16, 2019 · f3810f6 · f3810f6
1 parent 3732300
commit f3810f6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -1853,6 +1853,8 @@ const runTests = () => {
     const browser = core.getInput('browser')
     if (browser) {
       cmd.push('--browser')
+      // TODO should browser be quoted?
+      // If it is a path, it might have spaces
       cmd.push(browser)
     }
 

diff --git a/index.js b/index.js
@@ -250,6 +250,8 @@ const runTests = () => {
     const browser = core.getInput('browser')
     if (browser) {
       cmd.push('--browser')
+      // TODO should browser be quoted?
+      // If it is a path, it might have spaces
       cmd.push(browser)
     }