Skip to content

Outdated todomvc example used in github-actions (Rev2) #5126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MikeMcC399 opened this issue Mar 16, 2023 · 4 comments · Fixed by #6177
Closed

Outdated todomvc example used in github-actions (Rev2) #5126

MikeMcC399 opened this issue Mar 16, 2023 · 4 comments · Fixed by #6177
Labels
content: rewrite E2E triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team.

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Mar 16, 2023

Subject

GitHub-Action

Description

This is a follow-on from issue #5052 "Outdated todomvc example used in github-actions".

Location of issue

On https://docs.cypress.io/guides/continuous-integration/github-actions

GitHub Actions + Cypress Screencasts

links to 3. Example App Overview (https://youtu.be/zGrAhZkCoUE) which refers to github.com/cypress-io/todomvc

Problem description

The example app github.com/cypress-io/todomvc is outdated and cannot be used with Cypress 12.x.

The repository github.com/cypress-io/todomvc is now archived.
Edit: it is not archived at the moment (May 26, 2023).

Expectation

https://docs.cypress.io/guides/continuous-integration/github-actions should point to a non-archived repository which is capable of running on Cypress 12.x

Additional information

According to information from @nagash77 the repository

has been replaced by

Suggestion

  1. Add a forwarding message on cypress-io/todomvc to the replacement repository cypress-io/cypress-example-todomvc.
  2. Re-record the video, since the replacement repository is not a one-to-one replacement. For instance the instruction to use yarn build will not work:
    • there is no build script
    • using yarn causes a warning, since there is a package-lock.json file committed
@MikeMcC399
Copy link
Contributor Author

Comparing the old and new repo:

  1. The replacement repo github.com/cypress-io/cypress-example-todomvc includes package-lock.json from npm. If yarn is used, as instructed in the video, a warning is output.
  2. There is no build script.
  3. The start script is slightly different.
  4. The test script is different.
  5. yarn build does not work.

Here is a tabular comparison:

github.com/cypress-io/todomvc github.com/cypress-io/cypress-example-todomvc
yarn install npm install
build script no build necessary
start start
test test includes start
cypress:open cypress:open (no change)
yarn build no build necessary
yarn start npm start
yarn cypress:open npm run cypress:open

@MikeMcC399
Copy link
Contributor Author

@elylucas

@nagash77 nagash77 added triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. E2E labels Apr 28, 2023
@MikeMcC399
Copy link
Contributor Author

The repo https://github.com/cypress-io/todomvc is no longer archived.

Although the demo uses Cypress 7.0.0, it currently still works, even though it produces GitHub Actions deprecation notices.

Since it still works, I'm now closing this issue. It could be replaced with an enhancement suggestion to update.

@MikeMcC399 MikeMcC399 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2023
@MikeMcC399
Copy link
Contributor Author

The repo https://github.com/cypress-io/todomvc was archived again on May 16, 2024.

In the meantime the page has moved to https://docs.cypress.io/app/continuous-integration/github-actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content: rewrite E2E triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants