Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for the default email in the SMTP list when using the mailing and base IMAP draft implementation #464

Merged
merged 10 commits into from
May 5, 2021

Conversation

henrique-borba
Copy link
Contributor

@henrique-borba henrique-borba commented Apr 9, 2021

Pullrequest

Hotfix for #463

In the previous pull request, the SMTP profile user must have a domain to be found and selected. With this update, the SMTP module will try other ways of comparison to identify which SMTP profile to use.

I used a more direct way and put the responsibility of searching for the profile in the SMTP module itself instead of the IMAP module as discussed on Gitter.

IMAP Draft Support

When Draft Folders are configured for a specific IMAP account, the save button will use imap append to save the draft in the specific folder. Check todo list for upcoming necessary updates.

Issues

Checklist

  • None

How2Test

  • Configure a Draft folder for a specific draft account
  • Compose a new message
  • Save your composed message
  • Check if message shows in the configured Draft folder

@henrique-borba henrique-borba changed the title Hotfix for the default email in the SMTP list when using the mailing Hotfix for the default email in the SMTP list when using the mailing and base IMAP draft implementation Apr 9, 2021
@henrique-borba
Copy link
Contributor Author

@jasonmunro I think it's ready

@jasonmunro
Copy link
Member

I have not tested this yet but I like the looks of the code after a quick review, nice work and thanks! Merging to master now and we can resolve any issues that come up.

@jasonmunro jasonmunro merged commit 0db91c5 into cypht-org:master May 5, 2021
@henrique-borba
Copy link
Contributor Author

Thank you!

@marclaporte marclaporte mentioned this pull request Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants