Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] add functionality to send later scheduled sending #1091

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ENH] add functionality to send later scheduled sending #1091

wants to merge 1 commit into from

Conversation

amaninyumu1
Copy link
Member

@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 7aaffb2 to 0c58a6a Compare June 16, 2024 14:58
@marclaporte
Copy link
Member

Will this work with JMAP as well?

@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 0c58a6a to 0aef136 Compare June 19, 2024 08:09
@josaphatim josaphatim requested a review from kroky June 19, 2024 08:12
@amaninyumu1 amaninyumu1 marked this pull request as ready for review June 19, 2024 08:12
@kroky
Copy link
Member

kroky commented Jun 20, 2024

Yes, anything we add for IMAP, we should check JMAP support as well. Overall, it is built on top of IMAP, so it should work but please check if the new Scheduled folder is OK for JMAP.

Overall, the code is good but I have one concern - it only sends out while you are actively using Cypht and it seems to warn of unsent/scheduled messages each time you leave a page (onbeforeunload). That would be annoying for the end user. I believe this comment #576 (comment) proposes using sendAt support from jmap servers or scheduled send - if it is supported, we use it, if not, we fallback to a more annoying option. At any rate, it should be configurable.

This could be fully-supported in the Cypht-Tiki integration where there could be a Tiki command run periodically in the scheduler that checks and sends scheduled messages.

@josaphatim
Copy link
Member

@kroky I added a commit to fix issue concerning onbeforeunload event and also add the option to change schedule time or send the message immediately. Can you check please.

@josaphatim josaphatim force-pushed the Cypht-delay-send-later-scheduled-sending branch 2 times, most recently from 36599a8 to 2da4ff4 Compare June 27, 2024 13:45
@marclaporte
Copy link
Member

@amaninyumu1 If you need help with JMAP, please reach out to @Shadow243 as he set up a JMAP server for testing.

@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch 2 times, most recently from 45374ae to bdf9d5d Compare July 29, 2024 20:29
@Baraka24 Baraka24 force-pushed the Cypht-delay-send-later-scheduled-sending branch 5 times, most recently from cf0574d to af1c185 Compare August 2, 2024 10:21
@marclaporte
Copy link
Member

@amaninyumu1 "This branch has conflicts that must be resolved"

@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch 2 times, most recently from 141f8d9 to 16293f5 Compare September 14, 2024 06:13
@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 16293f5 to 41c9b95 Compare September 26, 2024 06:16
@amaninyumu1 amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 41c9b95 to 3fb7802 Compare October 8, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroky kroky Awaiting requested review from kroky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amaninyumu1 @marclaporte @kroky @josaphatim