Skip to content

Commit

Permalink
Arrow 16 Updates - fixes actions
Browse files Browse the repository at this point in the history
  • Loading branch information
mstaylor committed Dec 12, 2024
1 parent 3d3e28b commit 4810d09
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 11 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/conda-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ jobs:

- uses: conda-incubator/setup-miniconda@v2
with:
miniconda-version: "latest" # You can specify a version or leave it as "latest"
auto-update-conda: true
activate-environment: gcylon_dev
environment-file: conda/environments/gcylon.yml

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/conda-cpp-redis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
miniconda-version: "latest" # You can specify a version or leave it as "latest"
auto-update-conda: true
activate-environment: cylon_dev
environment-file: conda/environments/cylon.yml

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/conda-cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
miniconda-version: "latest" # You can specify a version or leave it as "latest"
auto-update-conda: true
activate-environment: cylon_dev
environment-file: conda/environments/cylon_NoUCX.yml

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ jobs:

- uses: conda-incubator/setup-miniconda@v2
with:
miniconda-version: "latest" # You can specify a version or leave it as "latest"
auto-update-conda: true
activate-environment: cylon_dev
environment-file: conda/environments/cylon_MacOS.yml

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ jobs:
- uses: actions/checkout@v2
- uses: conda-incubator/setup-miniconda@v2
with:
miniconda-version: "latest" # You can specify a version or leave it as "latest"
auto-update-conda: true
activate-environment: cylon_dev
environment-file: conda/environments/windows.yml

Expand Down
18 changes: 10 additions & 8 deletions conda/environments/cylon_NoUCX.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,17 @@ channels:
- conda-forge
- defaults
dependencies:
- python>=3.8,<3.10
- cmake>=3.23.1,!=3.25.0
- arrow-cpp=9
- pyarrow=9.0.0
- python>=3.9,<3.12
- cmake
- pyarrow=16.1.0
- libarrow-acero==16.1.0.*
- libarrow-dataset==16.1.0.*
- libarrow==16.1.0.*
- glog
- openmpi=4.1.3=ha1ae619_105
- cython>=0.29.31,<3
- numpy<1.24.4
- pandas>=1.0,<2.0.0
- openmpi
- cython>=0.29.31
- numpy>=1.23,<2.0a0
- pandas>=2.0,<2.2.3dev
- fsspec>=0.6.0
- setuptools
# they are not needed for using pygcylon or compiling it
Expand Down
6 changes: 3 additions & 3 deletions cpp/CMake/Modules/SetupCxxFlags.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ if(CYLON_CPU_FLAG STREQUAL "armv8")
if(NOT CXX_SUPPORTS_ARMV8_ARCH)
message(FATAL_ERROR "Unsupported arch flag: ${CYLON_ARMV8_ARCH_FLAG}.")
endif()
if(CYLON_ARMV8_ARCH_FLAG MATCHES "native")
message(FATAL_ERROR "native arch not allowed, please specify arch explicitly.")
endif()
# if(CYLON_ARMV8_ARCH_FLAG MATCHES "native")
# message(FATAL_ERROR "native arch not allowed, please specify arch explicitly.")
#endif()
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} ${CYLON_ARMV8_ARCH_FLAG}")

add_definitions(-DCYLON_HAVE_NEON)
Expand Down

0 comments on commit 4810d09

Please sign in to comment.