-
Notifications
You must be signed in to change notification settings - Fork 94
schema: add first parent descendants #6610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
markgrahamdawson
merged 1 commit into
cylc:master
from
oliver-sanders:first-parent-descendants
Mar 3, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -1226,36 +1226,50 @@ class Meta: | |||||
depth = Int() | ||||||
proxies = graphene.List( | ||||||
lambda: FamilyProxy, | ||||||
description='Associated cycle point proxies.', | ||||||
description='Associated family proxy instances.', | ||||||
args=PROXY_ARGS, | ||||||
strip_null=STRIP_NULL_DEFAULT, | ||||||
delta_store=DELTA_STORE_DEFAULT, | ||||||
delta_type=DELTA_TYPE_DEFAULT, | ||||||
resolver=get_nodes_by_ids) | ||||||
parents = graphene.List( | ||||||
lambda: Family, | ||||||
description='Family definition parent.', | ||||||
description='Families that this family directly inherits from.', | ||||||
args=DEF_ARGS, | ||||||
strip_null=STRIP_NULL_DEFAULT, | ||||||
delta_store=DELTA_STORE_DEFAULT, | ||||||
delta_type=DELTA_TYPE_DEFAULT, | ||||||
resolver=get_nodes_by_ids) | ||||||
child_tasks = graphene.List( | ||||||
Task, | ||||||
description='Descendant definition tasks.', | ||||||
description='Tasks that inherit from this family.', | ||||||
args=DEF_ARGS, | ||||||
strip_null=STRIP_NULL_DEFAULT, | ||||||
delta_store=DELTA_STORE_DEFAULT, | ||||||
delta_type=DELTA_TYPE_DEFAULT, | ||||||
resolver=get_nodes_by_ids) | ||||||
child_families = graphene.List( | ||||||
lambda: Family, | ||||||
description='Descendant desc families.', | ||||||
description='Families that inherit from this family.', | ||||||
args=DEF_ARGS, | ||||||
strip_null=STRIP_NULL_DEFAULT, | ||||||
delta_store=DELTA_STORE_DEFAULT, | ||||||
delta_type=DELTA_TYPE_DEFAULT, | ||||||
resolver=get_nodes_by_ids) | ||||||
descendants = graphene.List( | ||||||
String, | ||||||
description=sstrip(''' | ||||||
Linearised first-parent descendants. | ||||||
|
||||||
Inheritance in Cylc provides two functions: | ||||||
* Allowing tasks to inherit common configurations. | ||||||
* Defining a family/task hierarchy for visualisation purposes. | ||||||
(the linearised first-parent hierarchy). | ||||||
|
||||||
The visual hierarchy follows the first-parent of a family which | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
may differ from the full inheritance hierarchy. | ||||||
'''), | ||||||
) | ||||||
first_parent = Field( | ||||||
lambda: Family, | ||||||
description='Family first parent.', | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(rather minor suggestion, obviously)