Clarify task ID glob help #6606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
approved these changes
Feb 14, 2025
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Feb 14, 2025
* upstream/8.4.x: (244 commits) Clarify task ID glob help (cylc#6606) Wipe platform info for task killed during preparation Tidy API for submitting task jobs cat-log: list log files available via tailer/viewer command Remove Empy reference file pbs: update connection failed error message Mypy Add test Fix return value of `Scheduler.start_job_submission()` Replace functional test with integration test Add tests for `cylc kill` handlers & retries behaviour Kill tasks during job prep Tidy Update cylc/flow/parsec/validate.py Update changes.d/6571.fix.md Update cylc/flow/parsec/validate.py Assume task parameters with underscores to be strings. PEP-515 allowed integers to be defined with underscores from python 3.6. This changes the behaviour of Cylc task parameters, as `"123_456"` can now be interpreted as an integer. doc: improve run host ranking docs (cylc#6566) GH Actions: don't fail fast Lint S014: Only warn about `-W` when used for LSF (cylc#6551) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid any ambiguity, change globs match "active tasks" to "tasks in the n=0 active window".
And mention
cylc showas an exception - globs match in the n-window there.(This is easier than separately providing different glob help for
cylc showand for the rest; good enough for now as this will change again in the near-ish future).https://cylc.discourse.group/t/cylc-trigger-isnt-triggering-anything/1117/4
(I also made several lines in the ID help more concise - it's good to incrementally improve existing docs when we get a chance. If you can say it just as clearly in fewer words, that's a good thing, but it's damn near impossible to get optimal clarity+conciseness first try)
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.