Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix.ensure logger set for all caplog.set level #5920

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jan 12, 2024

caplog.set_level can conflict with other instances of caplog if the logger isn't set in the tests. This was causing the manylinux tests to fail, and would have caused the same problem if all pytests were run in the same task in the fast tests.

https://github.com/wxtim/cylc/actions/runs/7501317283 (PR's with changes to Python tests only trigger the fast-tests workflow - a neat feature, but somewhat unhelpful in this particular case)

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • This is a change to testing, no new test, documentation or changelog entries are reqd
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim changed the base branch from master to 8.2.x January 12, 2024 10:58
@wxtim wxtim force-pushed the fix.ensure_logger_set_for_all_caplog.set_level branch from 6a1111d to d0eb392 Compare January 12, 2024 11:06
@wxtim wxtim requested a review from oliver-sanders January 12, 2024 11:35
@wxtim
Copy link
Member Author

wxtim commented Jan 12, 2024

@oliver-sanders pick a second reviewer if you think it required.

@oliver-sanders oliver-sanders merged commit faf3c66 into cylc:8.2.x Jan 12, 2024
9 checks passed
@wxtim wxtim deleted the fix.ensure_logger_set_for_all_caplog.set_level branch January 12, 2024 11:52
@wxtim wxtim self-assigned this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants