Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: exclude report-timings and set 90% as the lower limit #5903

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

oliver-sanders
Copy link
Member

  • Exclude the deprecated report-timings command from code coverage.
  • Don't allow coverage to dip below 90%.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the cylc-8.3.0 milestone Jan 3, 2024
@oliver-sanders oliver-sanders requested a review from wxtim January 3, 2024 16:54
@oliver-sanders oliver-sanders self-assigned this Jan 3, 2024
@hjoliver
Copy link
Member

hjoliver commented Jan 3, 2024

Linter detected a stale link: http://code.activestate.com/recipes/66012-fork-a-daemon-process-on-unix/

Still listed by Google search, but the site does appear to down at the moment.

Anyway, nothing to do with this branch.

@wxtim wxtim merged commit dd8700e into cylc:master Jan 4, 2024
26 of 27 checks passed
@oliver-sanders oliver-sanders deleted the coverage branch January 4, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants