Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id: catch traceback in ID parsing #5896

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

oliver-sanders
Copy link
Member

Catch a niche traceback for invalid IDs like workflow///cycle/.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

* Catch a niche traceback for invalid IDs like `workflow///cycle/`.
@oliver-sanders oliver-sanders added bug Something is wrong :( small labels Dec 20, 2023
@oliver-sanders oliver-sanders added this to the cylc-8.2.4 milestone Dec 20, 2023
@oliver-sanders oliver-sanders requested a review from wxtim December 20, 2023 15:09
@oliver-sanders oliver-sanders self-assigned this Dec 20, 2023
@wxtim wxtim merged commit 69988b0 into cylc:8.2.x Jan 2, 2024
25 checks passed
@oliver-sanders oliver-sanders deleted the id-traceback branch January 2, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants